feat: call resolveId hooks in urlToBuiltUrl#1647
Closed
aleclarson wants to merge 3 commits into
Closed
Conversation
This is useful for rewriting asset urls in index.html and .css files
In some cases, rewritten asset urls do not point to actual files. For example, if the resolving plugin called `emitFile` from its `resolveId` hook, it can return "!__VITE_ASSET__xxx" to be replaced by Vite later on.
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Jan 22, 2021
...and any local non-module `<script>` tags. This is especially useful in combination with vitejs#1647.
This was referenced Jan 22, 2021
..after `resolveId` hook calls.
Contributor
Author
|
Hmm, perhaps introducing a edit: I see that Rollup has |
Contributor
Author
|
Closed in favor of #1675 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for rewriting asset urls in
index.htmland.cssfiles.Also in this PR: When a
resolveIdhook'simporterends with.cssor.html, the hook can prepend its return value with!to signify a built url, which skips thefileToBuiltUrlcall inurlToBuiltUrl. For example, if the resolving plugin calledemitFilefrom itsresolveIdhook, it can return!__VITE_ASSET__xxxto be replaced by Vite later on.I use these features in both
vite-plugin-publicandvite-plugin-rehost.