feat: global only alias#18005
Merged
patak-cat merged 2 commits intoSep 4, 2024
Merged
Conversation
|
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We started work to make
resolve.aliasper-environment at #17583. We discussed with the team that it isn't clear if this option should be per-environment, as it may require other tools reading Vite aliases to be aware of environments. The feature wasn't completely implemented either, as it would require we add one rollup alias plugin per environment (usingapplyToEnvironmentor a wrapper Vite plugin that wraps these and forwards the resolveId hook, unrelated to this PR but this would be a great use case for the functional plugins(environment) => pluginsthat we removed for now).This PR makes alias global only for now, and clarifies the Resolve types.
preserveSymlinksis also global only.