fix: always resolve runner's entry point#18013
Merged
sheremet-va merged 3 commits intoSep 4, 2024
Merged
Conversation
|
|
Member
|
I don't particularly understand the usecase for For the test, I think we can skip the hmr circular one for now, but I think it's correctly flagging a bug that we should look into later. |
Member
Author
Agree. Vitest has actually a use case for this in the mocker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #16358 (reply in thread)
Passing down a non-resolved ID to the module runner works for loading files, but it creates invalid module cache entries that don't work with HMR.
To resolve this, we always need to resolve entry points the same way Vite resolves URLs in the import analysis plugin. I see two possible solutions:
fetchModule(implemented in this PR)import, but this will probably break HMR in some way: