fix: handle trailing comma in Worker new URL multiline format#21316
Closed
saimskywalker wants to merge 1 commit into
Closed
fix: handle trailing comma in Worker new URL multiline format#21316saimskywalker wants to merge 1 commit into
new URL multiline format#21316saimskywalker wants to merge 1 commit into
Conversation
The Worker plugin regex did not handle trailing commas after `import.meta.url` when formatted by Prettier across multiple lines. This aligns the Worker plugin regex with the Asset plugin regex which already handles this case correctly.
Author
|
I found that CI lint check (pnpm prettier --write . && git diff --exit-code) was failing because Prettier reformatted my code:
But I need the multiline format to stay as-is because that's exactly what I'm testing (Worker with multiline URL and trailing comma). The Solution: // In main-module.js This tells Prettier to skip these blocks, keeping the multiline format I need for the test. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.