fix: check 0.0.0.0 when detecting if port is in use#21419
Closed
VedantMadane wants to merge 1 commit into
Closed
Conversation
Fixes vitejs#10638 When another server is listening on 0.0.0.0:port, Vite would still try to bind to localhost:port without detecting the conflict. This caused Vite to 'hijack' the port, responding to requests intended for the other server. The fix proactively checks if the port is accepting connections on 0.0.0.0 (and other relevant interfaces) before attempting to bind. If the port is in use, Vite will try the next available port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10638. When another server is on 0.0.0.0:port, Vite would still bind to localhost:port without detecting the conflict, hijacking the port. This fix proactively checks if the port accepts connections on 0.0.0.0 before binding.