Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"@rollup/pluginutils": "^5.3.0",
"@types/escape-html": "^1.0.4",
"@types/pnpapi": "^0.0.5",
"@vitejs/devtools": "^0.0.0-alpha.29",
"@vitejs/devtools": "^0.0.0-alpha.31",
"artichokie": "^0.4.2",
"baseline-browser-mapping": "^2.9.19",
"cac": "^6.7.14",
Expand Down Expand Up @@ -143,7 +143,7 @@
},
"peerDependencies": {
"@types/node": "^20.19.0 || >=22.12.0",
"@vitejs/devtools": "^0.0.0-alpha.24",
"@vitejs/devtools": "^0.0.0-alpha.31",
"esbuild": "^0.27.0",
"jiti": ">=1.21.0",
"less": "^4.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/rolldown.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ const nodeConfig = defineConfig({
'fsevents',
/^rolldown\//,
/^tsx\//,
/^@vitejs\/devtools\//,
/^#/,
'sugarss', // postcss-import -> sugarss
'supports-color',
'utf-8-validate', // ws
'bufferutil', // ws
'@vitejs/devtools/cli-commands',
...Object.keys(pkg.dependencies),
...Object.keys(pkg.peerDependencies),
],
Expand Down
43 changes: 26 additions & 17 deletions packages/vite/src/node/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ import {
type RolldownOptions,
rolldown,
} from 'rolldown'
import type { StartOptions } from '@vitejs/devtools/cli-commands'
import type {
DevToolsConfig,
ResolvedDevToolsConfig,
Comment thread
webfansplz marked this conversation as resolved.
} from '@vitejs/devtools/config'
import type { Alias, AliasOptions } from '#dep-types/alias'
import type { AnymatchFn } from '../types/anymatch'
import { withTrailingSlash } from '../shared/utils'
Expand Down Expand Up @@ -620,15 +623,6 @@ export interface ResolvedWorkerOptions {
rolldownOptions: RolldownOptions
}

export interface DevToolsConfig extends Partial<StartOptions> {
enabled: boolean
}

export interface ResolvedDevToolsConfig {
config: Omit<DevToolsConfig, 'enabled'> & { host: string }
enabled: boolean
}

export interface InlineConfig extends UserConfig {
configFile?: string | false
/** @experimental */
Expand Down Expand Up @@ -748,18 +742,32 @@ export interface ResolvedConfig extends Readonly<
export async function resolveDevToolsConfig(
config: DevToolsConfig | boolean | undefined,
host: string | boolean | undefined,
logger: Logger,
): Promise<ResolvedDevToolsConfig> {
const isEnabled = config === true || !!(config && config.enabled)
const resolvedHostname = await resolveHostname(host)
const fallbackHostname = resolvedHostname.host ?? 'localhost'

return {
enabled: config === true || !!(config && config.enabled),
const fallbackConfig = {
config: {
...(isObject(config) ? config : {}),
host: isObject(config)
? (config?.host ?? fallbackHostname)
: fallbackHostname,
host: fallbackHostname,
},
enabled: false,
}
if (!isEnabled) {
return fallbackConfig
}

try {
const { normalizeDevToolsConfig } = await import('@vitejs/devtools/config')
return normalizeDevToolsConfig(config, fallbackHostname)
} catch (e) {
logger.error(
colors.red(
`Failed to load Vite DevTools config: ${e.message || e.stack}`,
),
{ error: e },
)
return fallbackConfig
}
}

Expand Down Expand Up @@ -1863,6 +1871,7 @@ export async function resolveConfig(
const resolvedDevToolsConfig = await resolveDevToolsConfig(
config.devtools,
server.host,
logger,
)

resolved = {
Expand Down
2 changes: 1 addition & 1 deletion playground/devtools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
},
"devDependencies": {
"vite": "workspace:*",
"@vitejs/devtools": "^0.0.0-alpha.29"
"@vitejs/devtools": "^0.0.0-alpha.31"
}
}
44 changes: 22 additions & 22 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading