Skip to content

fix(css): show filename in CSS minification warnings for .css?inline #22292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
Apr 23, 2026
+4 −4
Merged

fix(css): show filename in CSS minification warnings for .css?inline #22292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ export function cssPostPlugin(config: ResolvedConfig): Plugin {
} else if (inlined) {
let content = css
if (config.build.cssMinify) {
content = await minifyCSS(content, config, true)
content = await minifyCSS(content, config, true, id)
}
code = `export default ${JSON.stringify(content)}`
} else {
Expand Down Expand Up @@ -2202,6 +2202,7 @@ async function minifyCSS(
css: string,
config: ResolvedConfig,
inlined: boolean,
filename: string = defaultCssBundleName,
) {
// We want inlined CSS to not end with a linebreak, while ensuring that
// regular CSS assets do end with a linebreak.
Expand All @@ -2213,6 +2214,7 @@ async function minifyCSS(
const { code, warnings } = await transform(css, {
loader: 'css',
target: config.build.cssTarget || undefined,
sourcefile: filename,
...resolveMinifyCssEsbuildOptions(config.esbuild || {}),
})
if (warnings.length) {
Expand All @@ -2239,9 +2241,7 @@ async function minifyCSS(
...config.css.lightningcss,
targets: convertTargets(config.build.cssTarget),
cssModules: undefined,
// TODO: Pass actual filename here, which can also be passed to esbuild's
// `sourcefile` option below to improve error messages
filename: defaultCssBundleName,
filename,
code: Buffer.from(css),
minify: true,
})
Expand Down
Loading