perf(vite): narrow test for changed files in esbuild plugin

[danielroe]

was browsing the codebase and noticed this pattern:

  if (changedFile.endsWith('.json')) {
    const cache = getTSConfigResolutionCache(server.config)
    if (changedFile.endsWith('/tsconfig.json')) {
      // ...
    }
  }

as getTSConfigResolutionCache doesn't seem to have side effects, and since #21622 the cache is only used in the second if block, I think we can slightly refactor. I've made an early return but could leave the if and simply reduce if checks by one.

it's a tiny, tiny improvement but thought it was worth it 🤷

[danielroe]

I don't think the failing test is related.

[sapphi-red]

This line actually should have || cache.hasParseResult(changedFile) like the condition in v7:

vite/packages/vite/src/node/plugins/esbuild.ts

Lines 520 to 523 in cc383e0

	if (
	changedFile.endsWith('/tsconfig.json') ||
	cache.hasParseResult(changedFile)
	) {

The fix is blocked by oxc-project/oxc-resolver#1011, but after we have that, the condition should be added.

So if the performance difference isn't significant, I'll prefer to keep the code as-is.

[danielroe]

ahh, that makes sense!