Conversation
| ).toEqual([ | ||
| // dispose for both dep and self | ||
| `foo was: 2`, | ||
| // `foo was: 2`, |
There was a problem hiding this comment.
This is actually an intentional fix because self-accepting callbacks should be called when a dep change bubbles up to the boundary. (e.g. #207)
| if (Array.isArray(deps) && deps.includes(changedPath)) { | ||
| deps.forEach((dep) => modulesToUpdate.add(dep)) | ||
| } else { | ||
| } else if (deps === changedPath) { |
There was a problem hiding this comment.
Removal of the check is intentional. This should be reverted.
There was a problem hiding this comment.
Also let's avoid mixing unrelated changes in the same PR.
There was a problem hiding this comment.
Copy that.
But I change it becasue any change will bubbles up to the boundary when i use hmr api for refactor vue file hmr.That will cause hmr don‘t minimize update for vue file.And also maybe the pr is unnessary.
There was a problem hiding this comment.
I revert this hmr change already.we can just do it with current hmr api.
|
I think something is going on with appveyor, the fails seem unrelated. |
I do it because i think it is useful for let the logics with built-in
vueprocess can be as an plugin.Well I think the hmr with vue module should be implement by hmr api, instead of use internal logicOther
I find top boundary will update self when deps is changed.eg blew case.
I think this bevaior should be handle by user self.
vitedon't do it because sometimes user don't hopeAfull-reload whenBchange.If the user want to do this bevaior.they can do like this blew.
Or better way. we can add hmr bubble for not accpet deps.And accpet deps should not bubble.Like this blew.
A should not update when B changed.A should update when C change.