fix(resolve): fix resolver not following node resolve algorithm#2718
Merged
Conversation
Shinigami92
reviewed
Mar 26, 2021
patak-cat
requested changes
Mar 26, 2021
patak-cat
approved these changes
Mar 26, 2021
Member
|
Note: this PR fixes edge cases (included in the tests) and improves performance when the project is using extensions in their imports. Before this PR, for the default config, 7 tryResolveFile would be called before trying for the exact match. With this PR, that 7 tryResolveFile are avoided. |
yyx990803
approved these changes
Mar 29, 2021
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fix #2695)
Description
Fixing resolver trying to postfix every file extension to path before trying to resolve to non-posfixed direct match.
Removed the ability to resolve to directory path while not in package.json and index resolution step.
Added 2 tests that previous implementation would fail.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).