Skip to content

feat(html): process static asset urls with urlToBuiltUrl#4273

Closed
aleclarson wants to merge 1 commit into
vitejs:mainfrom
aleclarson:feat/resolve-static-urls
Closed

feat(html): process static asset urls with urlToBuiltUrl#4273
aleclarson wants to merge 1 commit into
vitejs:mainfrom
aleclarson:feat/resolve-static-urls

Conversation

@aleclarson
Copy link
Copy Markdown
Contributor

Description

Files in /public referenced by index.html are now processed with urlToBuiltUrl.

Used by vite-plugin-public to insert a content hash.

Additional context

Follow-up to #1648


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Apr 1, 2023

Closing as outdated, and it seems that vite-plugin-public is using the older plugin format, so this PR wouldn't help it. If this feature is still needed, please open a new PR.

@bluwy bluwy closed this Apr 1, 2023
@bluwy
Copy link
Copy Markdown
Member

bluwy commented Apr 1, 2023

Actually it seems to not use an older plugin format, but the plugin uses a new feature in #1675. I'll continue the discussion in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: html needs test p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants