Skip to content

fix: use pkgId to get relative path (#4957)#4961

Merged
patak-cat merged 1 commit into
vitejs:mainfrom
meixg:main
Sep 17, 2021
Merged

fix: use pkgId to get relative path (#4957)#4961
patak-cat merged 1 commit into
vitejs:mainfrom
meixg:main

Conversation

@meixg
Copy link
Copy Markdown
Contributor

@meixg meixg commented Sep 17, 2021

Description

solve #4957

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 linked an issue Sep 17, 2021 that may be closed by this pull request
7 tasks
@Shinigami92 Shinigami92 self-requested a review September 17, 2021 09:47
@Shinigami92 Shinigami92 added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Sep 17, 2021
@patak-cat
Copy link
Copy Markdown
Member

Thanks for the fix @meixg, merging after testing locally. If you would like to keep collaborating, it would be good to have another PR that adds a test case for this. See https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#extending-the-test-suite

@patak-cat patak-cat merged commit b9e837a into vitejs:main Sep 17, 2021
@meixg meixg mentioned this pull request Nov 4, 2021
9 tasks
@meixg
Copy link
Copy Markdown
Contributor Author

meixg commented Nov 4, 2021

Thanks for the fix @meixg, merging after testing locally. If you would like to keep collaborating, it would be good to have another PR that adds a test case for this. See https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#extending-the-test-suite

@patak-js I just added a test case for this PR, see #5549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolveDeepImport does not support aliased packages

3 participants