fix: use pkgId to get relative path (#4957)#4961
Merged
Merged
Conversation
7 tasks
Shinigami92
approved these changes
Sep 17, 2021
patak-cat
approved these changes
Sep 17, 2021
Member
|
Thanks for the fix @meixg, merging after testing locally. If you would like to keep collaborating, it would be good to have another PR that adds a test case for this. See https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#extending-the-test-suite |
Contributor
Author
|
patak-cat
pushed a commit
that referenced
this pull request
Nov 4, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
solve #4957
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).