Skip to content

docs: fix typo in comment#5123

Merged
patak-cat merged 1 commit into
vitejs:mainfrom
benmccann:patch-2
Sep 28, 2021
Merged

docs: fix typo in comment#5123
patak-cat merged 1 commit into
vitejs:mainfrom
benmccann:patch-2

Conversation

@benmccann
Copy link
Copy Markdown
Collaborator

oops. I just noticed I had a typo in one of my previous commits

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vuejs/vite/GcfQidR5SppWFCpJfec5WKWH2pm1
✅ Preview: https://vite-git-fork-benmccann-patch-2-vuejs1.vercel.app

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Sep 28, 2021
@benmccann
Copy link
Copy Markdown
Collaborator Author

I realized while trying to use this method that SvelteKit isn't going to be able to leverage Vite's preview mode. I had previously exposed it as @experimental. Should I stop exposing it altogether or leave it in case someone else wants to use it?

@patak-cat
Copy link
Copy Markdown
Member

Could you explain a bit more why it wont be able to use it? I think we should leave the option though, other integrations may find it useful

@benmccann
Copy link
Copy Markdown
Collaborator Author

SvelteKit's preview does SSR rendering and Vite's doesn't. After digging into it more, I'm not sure that there's enough overlap between them to try to make SvelteKit share code on that path

@patak-cat patak-cat merged commit 96a2d15 into vitejs:main Sep 28, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants