chore: improve html plugin name#5158
Merged
Merged
Conversation
patak-cat
commented
Sep 30, 2021
patak-cat
commented
Sep 30, 2021
patak-cat
commented
Sep 30, 2021
Shinigami92
approved these changes
Oct 1, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
* chore: improve html plugin name * chore: spacing * chore: spacing * chore: spacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
htmlInlineScriptProxyPluginis namedvite:html. This plugin has a clear responsibility, that is to load inline scripts of entry html files as separate modules. I think it would be helpful to rename it accordingly so it shows with a more descriptive name in plugin inspect.This plugin is fundamental to the way Vite works, so IMO there isn't a chance that someone would depend in its name at this point (for example to remove it). It should be safe to merge even as a patch.
What is the purpose of this pull request?