Skip to content

fix(build): link href used data url #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyx990803 merged 2 commits into from
Jul 16, 2020
Merged

fix(build): link href used data url #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6728bfe
fix(build): link href used data url
underfin Jul 5, 2020
f880d0f
chore: add miss file
underfin Jul 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/node/build/buildPluginHtml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Plugin, RollupOutput, OutputChunk } from 'rollup'
import path from 'path'
import fs from 'fs-extra'
import { isExternalUrl, cleanUrl } from '../utils/pathUtils'
import { isExternalUrl, cleanUrl, isDataUrl } from '../utils/pathUtils'
import { resolveAsset, registerAssets } from './buildPluginAsset'
import {
parse as Parse,
Expand Down Expand Up @@ -189,7 +189,8 @@ const compileHtml = async (
p.type === NodeTypes.ATTRIBUTE &&
p.value &&
assetAttrs.includes(p.name) &&
!isExternalUrl(p.value.content)
!isExternalUrl(p.value.content) &&
!isDataUrl(p.value.content)
) {
assetUrls.push(p)
}
Expand Down
3 changes: 3 additions & 0 deletions src/node/utils/pathUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ export const parseWithQuery = (
const externalRE = /^(https?:)?\/\//
export const isExternalUrl = (url: string) => externalRE.test(url)

const dataUrlRE = /^\s*data:/i
export const isDataUrl = (url: string) => dataUrlRE.test(url)

const imageRE = /\.(png|jpe?g|gif|svg|ico|webp)(\?.*)?$/
const mediaRE = /\.(mp4|webm|ogg|mp3|wav|flac|aac)(\?.*)?$/
const fontsRE = /\.(woff2?|eot|ttf|otf)(\?.*)?$/i
Expand Down