fix(plugin-legacy): use terser when minifier is not specified#5231
Closed
OrekiSH wants to merge 1 commit into
Closed
fix(plugin-legacy): use terser when minifier is not specified#5231OrekiSH wants to merge 1 commit into
OrekiSH wants to merge 1 commit into
Conversation
Shinigami92
reviewed
Oct 8, 2021
Shinigami92
approved these changes
Oct 9, 2021
antfu
reviewed
Oct 9, 2021
Comment on lines
+100
to
+102
| const { minify } = config.build | ||
| if (typeof minify === 'undefined') { | ||
| config.build.minify = 'terser' |
Member
There was a problem hiding this comment.
Suggested change
| const { minify } = config.build | |
| if (typeof minify === 'undefined') { | |
| config.build.minify = 'terser' | |
| if (!config.build || config.build.minify === undefined) { | |
| return { build: { minify: 'terser' } } |
I think we should use return instead of mutating the config object directly. (also the case that config.build might be undefinded.
Contributor
Author
There was a problem hiding this comment.
Well, in factconfig.build has been set to {} if not exists in line 86. And return value in config option is a little confusing for me. It seems like no param reassign, but it actually mutated config globally.🤔
Member
|
It seems this is covered with #6272. |
Member
|
Closing the PR as it covered as stated by @sapphi-red. @OrekiSH let us know if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only use terser as the default minifier when minifier is not specified,
minify: false is useful in some cases I think.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).