fix(ssr): dont transform process.env. in ssr#5404
Merged
Merged
Conversation
9 tasks
patak-cat
reviewed
Oct 28, 2021
patak-cat
approved these changes
Oct 28, 2021
Shinigami92
approved these changes
Oct 28, 2021
7 tasks
|
It seems to me like this did not fix the problem. |
Member
Author
|
@sphinxc0re This fix isn't released in the latest SvelteKit version yet. We're waiting for a stable Vite release before doing so. |
|
Oh! Okay, I didn't know that 😅 my bad |
any workaround to make it work? |
Member
Author
|
You can temporarily do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In SSR and the SSR target is
node,process.env.will be left as is without transformation. Currently,process.env.FOOwill always be transformed as({}).FOO, which is undesirable when running in node.Additional context
Supersedes #4192 by @GrygrFlzr (most of the code is borrowed there and we should attribute GrygrFlzr too)
Fixes #3176
Re #3176 (comment), @benmccann and I had agreed that we should continue replacing
process.env.in client, but also warn the user that it would be undefined. I can make another PR for this if is desirable.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).