test: resolve using absolute dep path

[sanyuan0704]

Closes #5494

Description

Return the result of the pre-bundle product before resolvePlugin when import absolute dep path instead of bare import. See details in issue

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[bluwy]

It would also be great if we can add a test for this. I think the nested-dep playground would fit, with a test for absolute path in the vite config optimizeDeps.include. I think the path can be retrieved via path.resolve too instead of a hardcoded string.

[sanyuan0704]

It would also be great if we can add a test for this. I think the nested-dep playground would fit, with a test for absolute path in the vite config optimizeDeps.include. I think the path can be retrieved via path.resolve too instead of a hardcoded string.

But the path will be used in runtime code, such as import xxx from 'absolute-path'.

[bluwy]

But the path will be used in runtime code, such as import xxx from 'absolute-path'.

Ahh you're right. Hmm this one's hard to test, I'm fine if we leave it out for now as long as we add a comment in the code to explain the motivation (as you've proposed).

[sanyuan0704]

But the path will be used in runtime code, such as import xxx from 'absolute-path'.

Ahh you're right. Hmm this one's hard to test, I'm fine if we leave it out for now as long as we add a comment in the code to explain the motivation (as you've proposed).

We can execute a script in npm script, such as replace.js.

scripts: {
  "dev": "node replace.js && vite"
}

Then replace the outlet path with real absolute path.

[bluwy]

We can execute a script in npm script, such as replace.js.

scripts: {
  "dev": "node replace.js && vite"
}

Then replace the outlet path with real absolute path.

I think it's a bit brittle to do this (and may affect CI?). If someone run tests locally too, git would show a change for that file which could be confusing and lead to accidental updates.

[patak-cat]

Couldnt you use a plugin to rewrite a placeholder for the import path, or even use define directly?

[sanyuan0704]

Couldnt you use a plugin to rewrite a placeholder for the import path, or even use define directly?

Thanks，i will use resolve.alias replace the path.

[Shinigami92]

You need to run pnpm install in the root folder to regenerate lock file

[sanyuan0704]

You need to run pnpm install in the root folder to regenerate lock file

@bluwy @patak-js @Shinigami92 @daaku Hello, I'm not clear why does CI test always fail in windows environment.Can you help?

[patak-cat]

I think it is better if you use define instead here

import F from __F_ABSOLUTE_PACKAGE_PATH__

And in config use https://vitejs.dev/config/#define

define: {
  __F_ABSOLUTE_PACKAGE_PATH__: `JSON.stringify("${packageFPath}")`
}

If you are going to use an alias (that I think should also work), better to also use a constant name like the one above. Maybe Windows is having issues with the { char.

But for Windows you are probably missing a normalizePath, I'll comment in the code

[bluwy]

We may need to apply normalizePath here as well so that the server._optimizeDepsMetadata?.optimized[normalizePath(id)] expression below matches.

This brings up the edgecase as well, that we need to normalize the file path for optimizeDeps.include. I'm not sure if it's something we want, because otherwise we would need to omit the normalizePath usage in server._optimizeDepsMetadata?.optimized[normalizePath(id)], but that seems to cause CI errors too? I can't find the logs for when we had the code for that.

[patak-cat]

This is tricky, I'm not seeing consistent normalization in config options. Should assetsInclude be normalized? If you want it to work in both posix and windows, then all harcoded options should be normalized to posix, but if you are getting one with resolve, it may work without normalization. I'll ask in the next team meeting what is expected here. One option would normalize both when testing.

[sanyuan0704]

In windows, normalized path will be like D_home_vite_test and if such a path is placed in the include, esbuild will not be able to resolve it.

[patak-cat]

No, normalized paths using normalizePath only swap the windows \ by POSIX /

[sanyuan0704]

@patak-js I have added leading slash in the windows environment and now CI has succeeded。

[patak-cat]

Merged main removing the code change and only leaving the test cases, and these seem to work already without any modifications. I think we can merge this as a test PR