fix(plugin-react): React is not defined when component name is lowercase#6838
Merged
patak-cat merged 3 commits intovitejs:mainfrom May 2, 2022
Merged
Conversation
…wercase When the react variables (such as React__default) of the code in our third-party dependencies are converted to React, and the component name is lowercase, it is not converted to jsx, which will cause React to be undefined after restoring the code.
Contributor
|
could you include a test? |
xyl66
force-pushed
the
fix-plugin-react-restore-jsx-react-not-defined
branch
from
3da9a28 to
98d55e6
Compare
aleclarson
force-pushed
the
fix-plugin-react-restore-jsx-react-not-defined
branch
from
c913bc1 to
a09c8aa
Compare
aleclarson
force-pushed
the
fix-plugin-react-restore-jsx-react-not-defined
branch
from
a09c8aa to
37ca8f6
Compare
aleclarson
approved these changes
Feb 10, 2022
7 tasks
|
@patak-dev Would be great if this could get merged, many people seem to run into this issue, #7640 for example. |
patak-cat
approved these changes
May 2, 2022
patak-cat
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug describe and reproduce: #6537
This PR is fix React is not defined on production。
When the react variables (such as React__default) of the code in our third-party dependencies are converted to React, and the component name is lowercase, it is not converted to jsx, which will cause React to be undefined after restoring the code.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).