fix: prebundle dep with colon#7006
Merged
Merged
Conversation
patak-cat
approved these changes
Feb 20, 2022
Niputi
approved these changes
Feb 20, 2022
Shinigami92
approved these changes
Feb 20, 2022
|
I'm not sure if it's my environment but this doesn't seem to fix the issue in an Electron environment. version: "vite": "^2.8.5", Still getting an error when trying to import something using the node: protocol
|
7 tasks
Contributor
|
@tance77 vite don't support node builtins as they don't exist in the browser and is not part of the esm specification unless polyfilled or externalized. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6729
Closes #6364 (supersedes)
When importing a package like
node:url(aliased to a browser-safe package), handle the colon when flattening the id.Additional context
With aliases, technically the import path could be anything that needs to be escaped, but colon only for now sounds fine to be strict.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).