feat: add css config option, don't process CSS by default#1467
Merged
sheremet-va merged 8 commits intovitest-dev:mainfrom Jun 14, 2022
Merged
feat: add css config option, don't process CSS by default#1467sheremet-va merged 8 commits intovitest-dev:mainfrom
css config option, don't process CSS by default#1467sheremet-va merged 8 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
patak-cat
reviewed
Jun 12, 2022
packages/vitest/src/types/config.ts
Outdated
| * | ||
| * @default [/\.module\./] | ||
| */ | ||
| processCss?: boolean | RegExp[] |
Member
There was a problem hiding this comment.
This looks like a great DX improvement. About naming, given that there is already a css option in Vite, maybe this new option could be aligned with it:
css: {
include: RegExp | RegExp[], // @default [/\.module\./]
exclude: RegExp | RegExp[]
}
Removing the process in the name could be helpful if there are other CSS options added later. Or maybe css: boolean | { include, exclude } if you still want users to use css: true
Member
Author
There was a problem hiding this comment.
I think if we want to add more features to css, they should be added to Vite’s options :)
About the object - I think yes, we can align it with other similar options.
sheremet-va
changed the title
css config option, don't process CSS by default
patak-cat
reviewed
Jun 13, 2022
patak-cat
approved these changes
Jun 13, 2022
4 tasks
antfu
reviewed
Jun 13, 2022
antfu
reviewed
Jun 13, 2022
antfu
reviewed
Jun 13, 2022
antfu
reviewed
Jun 13, 2022
antfu
approved these changes
Jun 13, 2022
bgoscinski
reviewed
Jun 13, 2022
Co-authored-by: Bartosz Gościński <bargosc@gmail.com>
… feat/process-css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.