fix: fix crash when using happy-dom or jsdom environment on Yarn PnP workspaces#4698
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Dec 28, 2023
wojtekmaj:fix-pnp
Merged
fix: fix crash when using happy-dom or jsdom environment on Yarn PnP workspaces#4698sheremet-va merged 2 commits intovitest-dev:mainfrom wojtekmaj:fix-pnp
sheremet-va merged 2 commits intovitest-dev:mainfrom
wojtekmaj:fix-pnp
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4413
Description
Fixes an issue with Vitest crashing with cryptic error:
when using happy-dom or jsdom environment on Yarn PnP workspaces (note: this is NOT happening in "just" Yarn PnP).
Similarly to #4657, this "lifts" the logic up from local-pkg in order for PnP not to complain about local-pkg accessing packages that are not declared as its dependencies or peerDependencies.
I was unsure what to do
pnpm-lock.yamlbecause this PR technically adds a direct dependency (in reality, it "lifts" it, since it's already used inlocal-pkg), so lockfile had to be modified...How I tested it:
distdirectory to.yarn/unplugged/vitest-virtual-64d4633324/node_modules/vitest/dist; reinstalled repo:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.