Skip to content

fix(ui): show file item when search filter matches only test cases#4736

Merged
sheremet-va merged 6 commits intovitest-dev:mainfrom
hi-ogawa:fix-ui-file-filter-hidden-item
Dec 19, 2023
Merged

fix(ui): show file item when search filter matches only test cases#4736
sheremet-va merged 6 commits intovitest-dev:mainfrom
hi-ogawa:fix-ui-file-filter-hidden-item

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Dec 12, 2023

Description

Closes #4735

The left-most pane uses TasksList.nested = false and TasksTree.nested = false. In this case, hiding TaskItem based on search filter is not necessary since TasksList already decides which file to show based on its own logic.

I haven't added tests (EDIT: e2e is added in 84e5c8d) but manually confirmed the issue from the reproduction is fixed:

Reveal screenshot

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vitest UI: file filter display inconsistent with re-run test cases

2 participants