Skip to content

fix(vm-threads): tests not cancelled on key press, cancelled tests shown twice#4781

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
AriPerkkio:fix/test-interruption-vm-threads
Dec 28, 2023
Merged

fix(vm-threads): tests not cancelled on key press, cancelled tests shown twice#4781
sheremet-va merged 2 commits intovitest-dev:mainfrom
AriPerkkio:fix/test-interruption-vm-threads

Conversation

@AriPerkkio
Copy link
Copy Markdown
Member

@AriPerkkio AriPerkkio commented Dec 19, 2023

Description

  • Fixes bug where test run is not cancelled when one of the registered keys is pressed. This is only present on pool: 'vmThreads'.
  • Fixes bug where cancelled tests were shown twice by reporters

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants