Skip to content

fix(vitest): don't hang when mocking files with cyclic dependencies#4811

Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom
sheremet-va:fix/cyclic-import-original
Dec 28, 2023
Merged

fix(vitest): don't hang when mocking files with cyclic dependencies#4811
sheremet-va merged 4 commits intovitest-dev:mainfrom
sheremet-va:fix/cyclic-import-original

Conversation

@sheremet-va
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va commented Dec 27, 2023

Description

Fixes #4373

The problem was that the call stack didn't contain the file that triggered the mock factory execution - in this case importActual should behave the same way as a dynamic import.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vi.mock's importOriginal stuck on circular imports

2 participants