fix(vitest): auto-enable "github-actions" only where users didn't configure reporters#5158
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Feb 9, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on the discussion on discord https://discord.com/channels/917386801235247114/1123254125191241868/1205400484530225214, this PR changes
github-actionsto be auto-enabled only whenreportersare not explicitly provided by users.Though I think it makes sense, this would potentially make it harder for this feature to reach some people. I still kinda want to see this feature to be enabled automatically for any condition on v1.3.0 and later consider tweaking conditions based on users feedback. So, if doing something is really necessary, then I might prefer introducing yet-another variable like
VITEST_GITHUB_ACTIONS_REPORTER#5093 (comment) to allow opting out. What do you think?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.