Skip to content

fix(browser): produce valid config file if preview provider is used #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 2 commits into from
Aug 8, 2024
Merged

fix(browser): produce valid config file if preview provider is used #6305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72cc124
fix(browser): produce valid config file if preview provider is used
sheremet-va Aug 8, 2024
6a410fc
fix: update vue to fix the coverage
sheremet-va Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"dependencies": {
"@vueuse/core": "^10.11.0",
"vue": "^3.4.35"
"vue": "^3.4.37"
},
"devDependencies": {
"@iconify-json/carbon": "^1.1.37",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"unplugin-vue-components": "^0.27.3",
"vite": "^5.0.0",
"vite-plugin-pages": "^0.32.3",
"vue": "^3.4.35",
"vue": "^3.4.37",
"vue-router": "^4.4.2",
"vue-virtual-scroller": "2.0.0-beta.8"
}
Expand Down
4 changes: 2 additions & 2 deletions packages/vitest/src/create/browser/creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ async function generateWorkspaceFile(options: {
` },`,
`])`,
'',
].filter(c => c != null).join('\n')
].filter(c => typeof c === 'string').join('\n')
await writeFile(options.configPath, workspaceContent)
}

Expand Down Expand Up @@ -308,7 +308,7 @@ async function generateFrameworkConfigFile(options: {
` },`,
`})`,
'',
].join('\n')
].filter(t => typeof t === 'string').join('\n')
// this file is only generated if there is already NO root config which is an edge case
await writeFile(options.configPath, configContent)
}
Expand Down
Loading