Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 24, 2024

Description

I just noticed Vitest emits import analysis warning after the change #6724. For now I added a bunch of @vite-ignore for our tests.

Alternatively, we can probably silence this by default since adding @vite-ignore might not be an option for existing users when it's coming from inlined dependency. I made a PR for this approach #6785.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c1a2cda
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6719b1a90b75be00080636d1
😎 Deploy Preview https://deploy-preview-6784--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review October 24, 2024 02:56
@sheremet-va
Copy link
Member

Went with #6785.

@hi-ogawa hi-ogawa deleted the chore-import-vite-ignore branch October 29, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants