fix(coverage): isolate: false with istanbul provider#6935
Closed
AriPerkkio wants to merge 2 commits intovitest-dev:mainfrom
Closed
fix(coverage): isolate: false with istanbul provider#6935AriPerkkio wants to merge 2 commits intovitest-dev:mainfrom
isolate: false with istanbul provider#6935AriPerkkio wants to merge 2 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
AriPerkkio
commented
Nov 19, 2024
Comment on lines
+12
to
+19
| startCoverage() { | ||
| // @ts-expect-error -- untyped global | ||
| const coverageMap = globalThis[COVERAGE_STORE_KEY] as CoverageMapData | ||
|
|
||
| return coverage | ||
| } | ||
| // When isolated, there are no previous results | ||
| if (!coverageMap) { | ||
| return | ||
| } |
Member
Author
There was a problem hiding this comment.
Doing the reset here on startCoverage instead of stopCoverage should have better perf, as isolated tests won't ever run into this. Only non-isolated tests can have previous results in global scope.
Member
Author
|
Continues in #6957 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@vitest/coverage-v8Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.