feat(api)!: report test file also as a suite#7754
Closed
sheremet-va wants to merge 2 commits intovitest-dev:mainfrom
Closed
feat(api)!: report test file also as a suite#7754sheremet-va wants to merge 2 commits intovitest-dev:mainfrom
sheremet-va wants to merge 2 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AriPerkkio
requested changes
Mar 29, 2025
Member
AriPerkkio
left a comment
There was a problem hiding this comment.
I'm not sure I see the reason for this change. During #7069 we discussed this quite much and decided that suite hooks are intentionally optional and only explicitly called when suites are used.
What challenges did you run into that would require this change?
Member
Author
I found a few issues with our current approach:
|
Member
Author
|
Let's keep the API stable for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An idea I had while working on #7738. It felt weird that
onTestSuiteReady/onTestSuiteResultare never called if test files doesn't have any suites. This PR makes it so the test file is also treated as a suite by the reporter. It means:testCase.parentwill always be aTestSuitetestSuite.parentis nowTestSuite | undefined. If it'sundefined, then the current suite is the same as theTestModuleonTestSuiteReady/onTestSuiteResultis always calledPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.