Skip to content

fix(coverage): await profiler calls #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 1 commit into from
Apr 4, 2025
Merged

fix(coverage): await profiler calls #7763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions packages/coverage-v8/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,21 @@ const session = new inspector.Session()
let enabled = false

const mod: CoverageProviderModule = {
startCoverage({ isolate }) {
async startCoverage({ isolate }) {
if (isolate === false && enabled) {
return
}

enabled = true

session.connect()
session.post('Profiler.enable')
session.post('Profiler.startPreciseCoverage', {
callCount: true,
detailed: true,
})
await new Promise(resolve => session.post('Profiler.enable', resolve))
await new Promise(resolve =>
session.post(
'Profiler.startPreciseCoverage',
{ callCount: true, detailed: true },
resolve,
))
},

takeCoverage(options): Promise<{ result: ScriptCoverageWithOffset[] }> {
Expand All @@ -32,14 +34,19 @@ const mod: CoverageProviderModule = {
return reject(error)
}

const result = coverage.result
.filter(filterResult)
.map(res => ({
...res,
startOffset: options?.moduleExecutionInfo?.get(fileURLToPath(res.url))?.startOffset || 0,
}))
try {
const result = coverage.result
.filter(filterResult)
.map(res => ({
...res,
startOffset: options?.moduleExecutionInfo?.get(fileURLToPath(res.url))?.startOffset || 0,
}))

resolve({ result })
resolve({ result })
}
catch (e) {
reject(e)
}
})

if (provider === 'stackblitz') {
Expand All @@ -48,13 +55,13 @@ const mod: CoverageProviderModule = {
})
},

stopCoverage({ isolate }) {
async stopCoverage({ isolate }) {
if (isolate === false) {
return
}

session.post('Profiler.stopPreciseCoverage')
session.post('Profiler.disable')
await new Promise(resolve => session.post('Profiler.stopPreciseCoverage', resolve))
await new Promise(resolve => session.post('Profiler.disable', resolve))
session.disconnect()
},

Expand Down
Loading