fix: fix external behavior with deps.optimizer
#9125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8995
When optimizer is enabled for Vite SSR, Vite resolves non-optimized node_modules path with
?v=xxx. This confuses Vitest'sshouldExternalizelogic since you cannotreadFile(id)with query parameters, which then causes all node_modules to be inlined.Not exactly sure where and how much we should strip off queries. For this PR, it strips during
isValidNodeImportcheck only and keep queries for actual Node native import if it externalized as Node support that.Test
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.