Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 1, 2025

Description

Resolves #8980

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 71731f9
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/692d60b0a3346b00080126f1
😎 Deploy Preview https://deploy-preview-9137--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5ee887d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/692f95c8f1460c0007781a2f
😎 Deploy Preview https://deploy-preview-9137--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review December 2, 2025 00:42
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@9137

@vitest/browser-playwright

npm i https://pkg.pr.new/@vitest/browser-playwright@9137

@vitest/browser-preview

npm i https://pkg.pr.new/@vitest/browser-preview@9137

@vitest/browser-webdriverio

npm i https://pkg.pr.new/@vitest/browser-webdriverio@9137

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@9137

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@9137

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@9137

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@9137

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@9137

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@9137

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@9137

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@9137

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@9137

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@9137

vitest

npm i https://pkg.pr.new/vitest@9137

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@9137

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@9137

commit: c1ac76d

Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this TODO and /@id/ handling then?

// TODO: support more edge cases?

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Dec 3, 2025

Should we remove this TODO and /@id/ handling then?

// TODO: support more edge cases?

I just removed and CI passed, but not sure if there's a relevant test.

@hi-ogawa hi-ogawa requested a review from sheremet-va December 8, 2025 04:34
@sheremet-va sheremet-va merged commit 568513c into vitest-dev:main Dec 9, 2025
15 of 17 checks passed
@hi-ogawa hi-ogawa deleted the 12-01-fix_allow_inlining_fully_dynamic_import branch December 10, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4: plugins not applied to fully dynamic imports of node modules

2 participants