-
Notifications
You must be signed in to change notification settings - Fork 350
[Feat] add vllm-api-key #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @JustinDuy thanks for your contribution! Can you fix the DCO issue? (when committing, add Thanks a lot! |
|
@JustinDuy Thanks for contributing and it's great that you added functionality tests as well. Seems that |
f339947 to
1c9c691
Compare
|
|
@YuhanLiu11 , @ApostaC : i closed the PR by accident. Is it possible to re-open it? |
|
Great addition! |
|
@YuhanLiu11 , @ApostaC , @Shaoting-Feng , @gaocegege : Could anyone trigger the test and review please? |
ApostaC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM!
tutorials/06-secure-vllm-serve.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the file name since there are multiple new tutorials added recently. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ApostaC : Thank you! 've renamed the tutorial files. It's great to see the project advancing fast!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ApostaC : Could you please trigger the tests and merge if everything is ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ApostaC : One more time please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinDuy just started running the tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuhanLiu11, @ApostaC : Could you please trigger again? I increased the time-out. Look like we have this timeout error once in a while. Maybe timeout 2 mins should be increased also for the other helm tests...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinDuy tests passed! I'll merge it now.
a24705e to
cc1f91a
Compare
|
@JustinDuy seems to be some issues with the new test you added. 😢 Could you fix it when you get a chance? Thanks for your contribution! |
Signed-off-by: kbvd623 <duy.nguyen4@astrazeneca.com>
cc1f91a to
ee40147
Compare
YuhanLiu11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
FIX #150
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
Could you please review this @YuhanLiu11 , @ggaaooppeenngg ?