Skip to content

Conversation

@insukim1994
Copy link
Contributor

FILL IN THE PR DESCRIPTION HERE

FIX #363 (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

…d gpus. Initial commit.

Signed-off-by: insukim1994 <insu.kim@moreh.io>
…l test example output.

Signed-off-by: insukim1994 <insu.kim@moreh.io>
@insukim1994 insukim1994 marked this pull request as ready for review April 14, 2025 07:04
…requisites.

Signed-off-by: insukim1994 <insu.kim@moreh.io>
@YuhanLiu11
Copy link
Collaborator

Hey @insukim1994 This is a great PR! Thanks!
Can you make the tutorial file name to be something like 01-b-minimal-helm-installation-amd.md? Now we have two tutorials starting with 01-xx

@insukim1994
Copy link
Contributor Author

@YuhanLiu11 Sure! No problem! I will rename the tutorial readme file as your suggestion (01-b-minimal-helm-installation-amd.md).

…node (review updates).

Signed-off-by: insukim1994 <insu.kim@moreh.io>
@insukim1994
Copy link
Contributor Author

I renamed the tutorial readme file following your suggestion. Thank you for the feedback!

@YuhanLiu11
Copy link
Collaborator

@insukim1994 Thanks! Sorry for another comment, can you also change the value yaml you added to values-01-b-xxx.yaml?

@insukim1994
Copy link
Contributor Author

@YuhanLiu11 Sure no problem again! I will also rename the values file too based on your suggestion.

Copy link
Collaborator

@YuhanLiu11 YuhanLiu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@YuhanLiu11 YuhanLiu11 merged commit 8b5847d into vllm-project:main Apr 15, 2025
6 checks passed
@insukim1994
Copy link
Contributor Author

@YuhanLiu11 I'm very sorry for the confusion. I just renamed values file now but it seems already merged. Can you revert the merge and retry it again? Thank you

@insukim1994
Copy link
Contributor Author

@YuhanLiu11 Or I can create a new hotfix PR to add your suggestion. Let me know whichever way you prefer.

JustinDuy pushed a commit to JustinDuy/production-stack-1 that referenced this pull request Jun 13, 2025
…d gpus (vllm-project#364)

* [Feat] Added a tutorial document for deploying production stack on amd gpus. Initial commit.

Signed-off-by: insukim1994 <insu.kim@moreh.io>

* [Feat] Refined tutorial documentation format and sentences. Added real test example output.

Signed-off-by: insukim1994 <insu.kim@moreh.io>

* [Feat] Added a guide refers to the link for amd gpu related setup prerequisites.

Signed-off-by: insukim1994 <insu.kim@moreh.io>

* [Feat] Renamed filename for minimal helm example tutorial on amd gpu node (review updates).

Signed-off-by: insukim1994 <insu.kim@moreh.io>

---------

Signed-off-by: insukim1994 <insu.kim@moreh.io>
allytotheson pushed a commit to allytotheson/production-stack that referenced this pull request Jun 30, 2025
…d gpus (vllm-project#364)

* [Feat] Added a tutorial document for deploying production stack on amd gpus. Initial commit.

Signed-off-by: insukim1994 <insu.kim@moreh.io>

* [Feat] Refined tutorial documentation format and sentences. Added real test example output.

Signed-off-by: insukim1994 <insu.kim@moreh.io>

* [Feat] Added a guide refers to the link for amd gpu related setup prerequisites.

Signed-off-by: insukim1994 <insu.kim@moreh.io>

* [Feat] Renamed filename for minimal helm example tutorial on amd gpu node (review updates).

Signed-off-by: insukim1994 <insu.kim@moreh.io>

---------

Signed-off-by: insukim1994 <insu.kim@moreh.io>
Signed-off-by: allytotheson <82621261+allytotheson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Tutorial for deploying production stack on AMD GPU nodes will be helpful

2 participants