-
Notifications
You must be signed in to change notification settings - Fork 350
[Feat] Added a tutorial document for deploying production stack on amd gpus #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Added a tutorial document for deploying production stack on amd gpus #364
Conversation
…d gpus. Initial commit. Signed-off-by: insukim1994 <insu.kim@moreh.io>
…l test example output. Signed-off-by: insukim1994 <insu.kim@moreh.io>
…requisites. Signed-off-by: insukim1994 <insu.kim@moreh.io>
|
Hey @insukim1994 This is a great PR! Thanks! |
|
@YuhanLiu11 Sure! No problem! I will rename the tutorial readme file as your suggestion (01-b-minimal-helm-installation-amd.md). |
…node (review updates). Signed-off-by: insukim1994 <insu.kim@moreh.io>
|
I renamed the tutorial readme file following your suggestion. Thank you for the feedback! |
|
@insukim1994 Thanks! Sorry for another comment, can you also change the value yaml you added to values-01-b-xxx.yaml? |
|
@YuhanLiu11 Sure no problem again! I will also rename the values file too based on your suggestion. |
YuhanLiu11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
@YuhanLiu11 I'm very sorry for the confusion. I just renamed values file now but it seems already merged. Can you revert the merge and retry it again? Thank you |
|
@YuhanLiu11 Or I can create a new hotfix PR to add your suggestion. Let me know whichever way you prefer. |
…d gpus (vllm-project#364) * [Feat] Added a tutorial document for deploying production stack on amd gpus. Initial commit. Signed-off-by: insukim1994 <insu.kim@moreh.io> * [Feat] Refined tutorial documentation format and sentences. Added real test example output. Signed-off-by: insukim1994 <insu.kim@moreh.io> * [Feat] Added a guide refers to the link for amd gpu related setup prerequisites. Signed-off-by: insukim1994 <insu.kim@moreh.io> * [Feat] Renamed filename for minimal helm example tutorial on amd gpu node (review updates). Signed-off-by: insukim1994 <insu.kim@moreh.io> --------- Signed-off-by: insukim1994 <insu.kim@moreh.io>
…d gpus (vllm-project#364) * [Feat] Added a tutorial document for deploying production stack on amd gpus. Initial commit. Signed-off-by: insukim1994 <insu.kim@moreh.io> * [Feat] Refined tutorial documentation format and sentences. Added real test example output. Signed-off-by: insukim1994 <insu.kim@moreh.io> * [Feat] Added a guide refers to the link for amd gpu related setup prerequisites. Signed-off-by: insukim1994 <insu.kim@moreh.io> * [Feat] Renamed filename for minimal helm example tutorial on amd gpu node (review updates). Signed-off-by: insukim1994 <insu.kim@moreh.io> --------- Signed-off-by: insukim1994 <insu.kim@moreh.io> Signed-off-by: allytotheson <82621261+allytotheson@users.noreply.github.com>
FILL IN THE PR DESCRIPTION HERE
FIX #363 (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.