-
Notifications
You must be signed in to change notification settings - Fork 350
[Router] Expose /tokenize and /detokenize endpoints #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Router] Expose /tokenize and /detokenize endpoints #541
Conversation
Signed-off-by: Ivan Rajwa Naufal <ivan.naufal@datacomm.co.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Exchioz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to extend the vllm_router's capabilities by exposing the /tokenize and /detokenize endpoints from the vLLM backend. This makes tokenization and detokenization functionalities directly accessible through the production API, enabling users to leverage these features for various use cases like prompt preparation and token usage analysis.
Highlights
- New API Endpoints: I've added two new
POSTendpoints,/tokenizeand/detokenize, to themain_router. - Backend Proxying: These new endpoints are configured to proxy requests directly to their corresponding vLLM backend services using the existing
route_general_requestutility, mirroring the behavior of other established routes like/completionsand/embeddings.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds /tokenize and /detokenize endpoints to the main router by reusing the route_general_request function. My review identifies a high-severity issue with this approach. The route_general_request function requires a model field in the request body for routing, which is not part of the standard vLLM API for these new endpoints. This will cause requests using the standard API to fail and creates an inconsistency between the router and the backend. I've recommended creating a dedicated routing function for these endpoints to handle this correctly.
|
This is a super helpful feature! Thanks @Exchioz . We'll take a look on our side. |
|
Can you provide a minimal example demonstrating how these endpoints work? |
|
Hi @Shaoting-Feng, thanks for the review! Here's an example demonstrating how to 1.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please update branch and we are ready to go.
|
I figured the required format for the |
Signed-off-by: Ivan Rajwa Naufal <ivan.naufal@datacomm.co.id> Co-authored-by: Ivan Rajwa Naufal <ivan.naufal@datacomm.co.id> Co-authored-by: Yuhan Liu <32589867+YuhanLiu11@users.noreply.github.com> Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
[Router] Expose
/tokenizeand/detokenizeendpointsThis PR adds support for forwarding
/tokenizeand/detokenizerequests through thevllm_router. These endpoints already exist in the vLLM backend but were not exposed by the production router.This change enables users to access tokenization and detokenization functionality via the production-stack API, which is useful for analyzing token usage, preparing prompts, and monitoring inference behavior
Summary of Changes
@main_router.post("/tokenize")and@main_router.post("/detokenize")routes.route_general_request(...)to proxy to the backend vLLM endpoints./completionsand/embeddings.Fixes
No existing issue yet. Feel free to reference if created later.
Checklist