-
Notifications
You must be signed in to change notification settings - Fork 350
[Feat][Helm] Add HTTPRoute template for Gateway API support #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Hexoplon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented support for the Kubernetes Gateway API's HTTPRoute resource within the Helm chart. This enhancement allows for highly flexible and configurable routing rules for the router service, including the ability to define multiple routes and manage automatic HTTPS redirects. This change significantly improves the traffic management capabilities and integration with modern Kubernetes networking.
Highlights
- Gateway API HTTPRoute Template: I've added a new Helm template (
helm/templates/route.yaml) to generate KubernetesHTTPRouteresources, enabling integration with the Gateway API for advanced traffic management. - Flexible Routing Configuration: I've introduced a new
routerSpec.routesection inhelm/values.yamlthat provides extensive configuration options for theHTTPRoute, includingapiVersion,kind,annotations,labels,hostnames,parentRefs,httpsRedirect,matches,filters, andadditionalRules. - Support for Multiple Routes and Redirects: The new configuration allows defining multiple HTTP routes and includes a convenient option for automatic HTTPS redirects, enhancing the router's traffic handling capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Kubernetes Gateway API HTTPRoutes via a new Helm template, which is a valuable addition for enabling flexible traffic routing to the vLLM router. The implementation is well-structured and follows patterns from other popular Helm charts. I've identified a logical inconsistency in the new route template where its behavior doesn't align with the documentation in values.yaml, and a minor typo in a comment. My review includes suggestions to correct these issues to ensure the feature works as documented.
a655d6c to
37b1283
Compare
|
Hi, This is a super great feature! Can you add the gateway class and gateway too? And maybe provide a tutorial to show how to use this feature? |
I could some doc lines pointing to something like https://gateway-api.sigs.k8s.io/guides/simple-gateway/ and a simple setup, but in my opinion the helm chart should not include a gateway template. In the same way that it does not include an ingress controller for the ingress, as gateways typically are cluster level resources. There already is some docs on using the gateway api, but with the inference extension https://docs.vllm.ai/projects/production-stack/en/latest/deployment/gateway-inference-extension.html |
|
Hi I mean adding gateway and gateway class examples along with tutorials. More like the tutorials and assets folder in the project. |
Add a route template to allow for configuring k8s Gateway API HTTP (or other) routes. See https://gateway-api.sigs.k8s.io/ Signed-off-by: Zackeus Bengtsson <github@zackeus.no>
37b1283 to
3ca78b5
Compare
I added a tutorial reusing KGateway from the Gateway inference API extension tutorial, and a minimalistic values example to setup HTTPS with a self signed certificate, and HTTP redirect |
zerofishnoodles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Footnotes
|
|
Thank you for the comprehensive summary, @mtgralanbr! This is very helpful for understanding the scope and impact of the changes related to the Kubernetes Gateway API integration. |
…ject#610) Add a route template to allow for configuring k8s Gateway API HTTP (or other) routes. See https://gateway-api.sigs.k8s.io/ Signed-off-by: Zackeus Bengtsson <github@zackeus.no> Co-authored-by: Yuhan Liu <32589867+YuhanLiu11@users.noreply.github.com> Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
Add a route template to allow for configuring k8s Gateway API HTTP (or other) routes. See https://gateway-api.sigs.k8s.io/
Heavily inspired by the kube-prometheus-stack helm chart. This allow for great flexibility in terms of configuring multiple routes, or something like one https route and one http route for automatic redirects.
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.