[Feat][Router] Add configurable timeout_seconds for Kubernetes watchers #654
Conversation
Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
…or watcher streams - Introduced parameter in and classes to allow dynamic timeout settings. - Updated relevant methods to utilize the new timeout configuration instead of hard-coded values. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ikaadil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new configuration option to control the timeout for Kubernetes watchers within the vllm_router. Previously, the timeout for discovering vLLM pods and services was hardcoded, but now it can be specified via a command-line argument, providing greater flexibility for deployment environments.
Highlights
- Configurable Kubernetes Watcher Timeout: Introduced --k8s-timeout-seconds command-line argument to allow users to specify the timeout for Kubernetes API watcher streams.
- Dynamic Timeout Application: The hardcoded 30-second timeout for Kubernetes pod and service watchers has been replaced with the newly configurable value, improving adaptability.
- Argument Propagation: The new timeout argument is correctly propagated from the application's argument parser to the Kubernetes service discovery initialization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable timeout for Kubernetes watchers via the --k8s-timeout-seconds command-line argument. The changes are well-implemented, plumbing the new argument from the parser down to the Kubernetes service discovery classes where it replaces a hardcoded value. This improves configurability and resolves a TODO item.
My main feedback is to add validation for the new k8s-timeout-seconds argument to ensure it's a positive integer, as a non-positive value could lead to a runtime error. I've left a specific comment on this.
Overall, this is a good and useful feature addition.
…in the parser. This change enhances error handling for Kubernetes service discovery configurations. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
|
@YuhanLiu11 could you please review this PR? |
…her_timeout_seconds' instead of 'timeout_seconds'. Updated related validation and argument parsing to reflect this change, enhancing clarity and configurability for watcher stream timeouts. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
Yes
I renamed it to
Currently k8s has |
…rs (vllm-project#654) * Add --k8s-timeout-seconds argument for Kubernetes watcher streams Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> * Enhance Kubernetes service discovery by adding configurable timeout for watcher streams - Introduced parameter in and classes to allow dynamic timeout settings. - Updated relevant methods to utilize the new timeout configuration instead of hard-coded values. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> * Validate k8s-timeout-seconds argument to ensure it is greater than 0 in the parser. This change enhances error handling for Kubernetes service discovery configurations. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> * Refactor Kubernetes service discovery timeout parameters to use 'watcher_timeout_seconds' instead of 'timeout_seconds'. Updated related validation and argument parsing to reflect this change, enhancing clarity and configurability for watcher stream timeouts. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> --------- Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
…rs (vllm-project#654) * Add --k8s-timeout-seconds argument for Kubernetes watcher streams Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> * Enhance Kubernetes service discovery by adding configurable timeout for watcher streams - Introduced parameter in and classes to allow dynamic timeout settings. - Updated relevant methods to utilize the new timeout configuration instead of hard-coded values. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> * Validate k8s-timeout-seconds argument to ensure it is greater than 0 in the parser. This change enhances error handling for Kubernetes service discovery configurations. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> * Refactor Kubernetes service discovery timeout parameters to use 'watcher_timeout_seconds' instead of 'timeout_seconds'. Updated related validation and argument parsing to reflect this change, enhancing clarity and configurability for watcher stream timeouts. Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> --------- Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com> Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
3 participants
FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.