[Bugfix/Feature] Support extraPorts in service-vllm

[NargiT]

• Extra ports for serverEngine is half done, this pr aim to fill the gap so the service can be extended with extra ports.
  Useful for istio.
• Adding also support for routers to allow application like istio scrap metrics

---

• Make sure the code changes pass the pre-commit checks.
• Sign-off your commit by using -s when doing git commit
• Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].

Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

• [Bugfix] for bug fixes.
• [CI/Build] for build or continuous integration improvements.
• [Doc] for documentation fixes and improvements.
• [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
• [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
• [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

• Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
• The code need to be well-documented to ensure future contributors can easily understand the code.
• Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

[gemini-code-assist]

Summary of Changes

Hello @NargiT, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the support for defining and exposing extraPorts within the service-vllm Helm chart. This enhancement provides greater flexibility for extending the service, particularly for integrations with service meshes like Istio, by allowing users to specify additional ports through a well-defined and validated configuration schema.

Highlights

• Extra Ports Support: Completed the implementation for extraPorts in the service-vllm Helm chart, allowing additional ports to be exposed for the serving engine.
• Schema Definition: Introduced a comprehensive schema for servingEngineSpec.extraPorts in values.schema.json, ensuring proper validation and structure for user-defined ports.
• Helm Chart Integration: Integrated the chart.extraPorts helper into service-vllm.yaml to dynamically include these additional port definitions in the Kubernetes service.
• Configuration Example: Provided a commented-out example in values.yaml demonstrating how to configure extraPorts, specifically for an Istio sidecar metrics port.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR fixes incomplete implementation of extraPorts support in the service-vllm Helm chart. The feature allows adding additional ports to the VLLM service, which is useful for integrations like Istio sidecar metrics.

• Adds extraPorts configuration to the values.yaml template with Istio example
• Defines JSON schema validation for the extraPorts array structure
• Integrates extraPorts into the service-vllm.yaml template and fixes helper template formatting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
helm/values.yaml	Adds commented example configuration for extraPorts with Istio sidecar metrics
helm/values.schema.json	Defines comprehensive JSON schema validation for extraPorts array with port specifications
helm/templates/service-vllm.yaml	Integrates extraPorts helper template into the service specification
helm/templates/_helpers.tpl	Fixes YAML indentation in the extraPorts helper template

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Code Review

This pull request adds support for extraPorts in the service-vllm Helm chart, allowing users to expose additional ports from the serving engine. The changes include updating the service template, adding a helper for the extra ports, defining the schema in values.schema.json, and providing an example in values.yaml. The implementation is solid, but I found a minor typo in the example provided in values.yaml which could cause issues for users if they copy it.

[NargiT]

/gemini review

[gemini-code-assist]

Code Review

This pull request aims to add support for extraPorts in the service-vllm service, which is a useful feature for integrations like Istio. The changes span across the Helm templates, values schema, and default values. While the overall approach is sound, there's a critical issue in helm/templates/service-vllm.yaml where the current implementation can produce invalid YAML if extraPorts is not defined. I've provided a suggestion to fix this by conditionally including the ports. The other changes, including the schema definition and the example in values.yaml, are well-implemented.

[zerofishnoodles]

LGTM