-
Notifications
You must be signed in to change notification settings - Fork 349
[Build][Router] Update vllm to v0.13.0 #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @shernshiou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical build update for the router component, primarily by upgrading several key Python dependencies. The main objective is to address and reduce existing Common Vulnerabilities and Exposures (CVEs) found in the current Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies, including vllm, lmcache, and fastapi, to address security vulnerabilities as described. The changes are correct and consistently applied across the relevant files. I have one suggestion to improve dependency management consistency between pyproject.toml and requirements.txt, which I've detailed in a review comment.
|
Hi Can you revert the change to the uv lock since there are too many change line in that. |
Hi @zerofishnoodles |
2eef67b to
b0ac576
Compare
|
@zerofishnoodles I have reset the uv.lock |
|
I believe a production-stack release should follow this update as well, right? |
Yes it should be. It is just that we don't want too many changes in one PR. Also since pyproject itself should be enough for the venv. |
Yes it should be |
ed93ada to
45c3563
Compare
Signed-off-by: Shern Shiou Tan <shernshiou@gmail.com>
45c3563 to
8c02adf
Compare
The latest lmcache/lmstack-router docker image (lmcache/lmstack-router:0.1.9.dev4-ge1447afd3.d20251215) contains several CVEs including CVEs belonging to vllm v0.11.0 and also older version of starlette. Updating vllm to v0.12.0 reduces the CVEs and also update the starlette to the version without CVE.
-swhen doinggit commit[Bugfix],[Feat], and[CI].: