-
Notifications
You must be signed in to change notification settings - Fork 349
feat(router): add initial support for anthropic messages endpoint #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nejc Habjan <nejc.habjan@siemens.com>
Summary of ChangesHello @nejch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational support for handling Anthropic-style Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces initial support for the Anthropic messages API endpoint (/v1/messages) by adding a new router to forward these requests to the vLLM backend. The changes are well-structured and align with the existing codebase patterns. My review includes one suggestion to refactor a piece of duplicated code in the test payload generation logic to enhance maintainability. Overall, the implementation is solid and effectively accomplishes its goal.
| case ModelType.messages: | ||
| return { | ||
| "messages": [ | ||
| { | ||
| "role": "user", | ||
| "content": "Hello", | ||
| } | ||
| ], | ||
| "temperature": 0.0, | ||
| "max_tokens": 3, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this makes sense as we're actually inside get_test_payload here, so it wouldn't be that intuitive for humans. I can factor out the payload itself if needed to avoid duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding a separate module just in case, so we can add future Anthropic-compatible endpoints here if needed.
| case ModelType.messages: | ||
| return { | ||
| "messages": [ | ||
| { | ||
| "role": "user", | ||
| "content": "Hello", | ||
| } | ||
| ], | ||
| "temperature": 0.0, | ||
| "max_tokens": 3, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this makes sense as we're actually inside get_test_payload here, so it wouldn't be that intuitive for humans. I can factor out the payload itself if needed to avoid duplication.
| return "/v1/score" | ||
| case ModelType.transcription: | ||
| return "/v1/audio/transcriptions" | ||
| case ModelType.messages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly cosmetics at the moment, since compatible models presumably have chat defined as their type, but maybe in the future it'd make sense to support multiple types and run health checks against supported endpoints.
This is a follow-up to vllm-project/vllm#21313, a simple initial PR adding support here to route requests to
/v1/messagesin vLLM itself without transforming requests here.Hopefully we can later extend this to also route to Anthropic endpoints themselves, e.g. via bedrock, but that needs some healthcheck refactoring first.
Related to Anthropic tasks in #640
Also related to #278
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.