refactor(core): complete library rewrite with modern architecture#3
Merged
Conversation
- Add support for both string and object formats in price/total_item_price - Extract currency from price object when available - Add robust error handling for price parsing - Maintain backward compatibility with existing format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete refactor of the library with modernized client architecture, improved cookie persistence, and comprehensive documentation updates.
Key Changes
Core Architecture
VintedClientwith clean async context manager patternStorage & Persistence
Models & Parsing
CatalogItemandDetailedItemDocumentation
Testing & CI
Breaking Changes
vinted_api_kit→vintedVintedApi→VintedClientlocaleparameter (auto-detected)How to Test
Run checks:
Smoke test:
Cookie persistence test:
Safety Notes
json(safe, portable)pickleformat available but documented as unsafe for untrusted dataPost-Merge Actions
pyproject.tomlto1.0.0CHANGELOG.mdwith release noteshatch build