Fix Protector Gariel's broadcast text

[GoonBoiBarry]

🍰 Pullrequest

Fixes the broadcast text not displaying for Protector Gariel.

Proof

Was already implemented, but broke from other db updates.

Issues

• closes: 🐛 [Bug]Protector Gariel is not saying their broadcast text anymore #3182

How2Test

• .go creature 89531 and wait for broadcast text

Todo / Checklist

• None

[AnonXS]

This seems to be the better fix, not sure if original data was wrong, or if something was made wrong with recent updates.

https://wow.zamimg.com/uploads/screenshots/normal/39099-protector-gariel.jpg

UPDATE `creature_display_info_addon` SET `gender` = 1 WHERE `display_id` IN (2367); -- seemingly also wrong in wotlkmangos

[GoonBoiBarry]

This seems to be the better fix, not sure if original data was wrong, or if something was made wrong with recent updates.

https://wow.zamimg.com/uploads/screenshots/normal/39099-protector-gariel.jpg

UPDATE `creature_display_info_addon` SET `gender` = 1 WHERE `display_id` IN (2367); -- seemingly also wrong in wotlkmangos

I agree, I just didn't wanna undo something that had already been sniffed. This is the update that broke it fyi:

core/sql/migrations/20231113023934_world.sql

Line 1317 in 6633dbb

UPDATE `creature_display_info_addon` SET `gender`=0 WHERE `display_id`=2367;

[FlagFlayer]

I think the mistake is that Protector Gariel is the one saying it in the first place. It should be said by Scout Riell:

Screenshot from the alpha project archive:

Also says it's a quote on wowhead, though I give less credence to that: https://www.wowhead.com/classic/npc=820/scout-riell

[FlagFlayer]

FYI there should never be mistakes in broadcast_text, it's all perfectly sniffed data.

[Daribon]

Originally from this commit:
5a6d083

Which was copied from this TC commit:
TrinityCore/TrinityCore@7a0f1d7

None of the above have I've seen in any sniffs, videos, or screenshots from either release vanilla or classic. It doesn’t seem like the original TC commit was based on a sniff at all, which raises the question of whether the other NPC changes in that commit are even accurate.

[FlagFlayer]

The text assigned to Protector Bialon is actually from Scout Galiaan. The rest is assigned correctly but probably implemented arbitrarily.

[GoonBoiBarry]

FYI there should never be mistakes in broadcast_text, it's all perfectly sniffed data.

This is good to know.

Sounds like this pull should probably be closed then, cause I'm pretty sure Vmangos doesn't do temporary fixes if the content is no longer considered blizzlike. I'll leave it up for big man to decide