Skip to content

Allow users to unset git flags by passing them as empty string#449

Merged
warango4 merged 1 commit intovmware-tanzu:mainfrom
warango4:issue424
Jan 20, 2023
Merged

Allow users to unset git flags by passing them as empty string#449
warango4 merged 1 commit intovmware-tanzu:mainfrom
warango4:issue424

Conversation

@warango4
Copy link
Copy Markdown
Contributor

Pull request

What this PR does / why we need it

Allow to remove git fields from workload by passing them as empty strings through flags.

Which issue(s) this PR fixes

Fixes #424

Describe testing done for PR

  • Modified different workloads in local cluster
  • Added unit tests

Additional information or special notes for your reviewer

Signed-off-by: Wendy Arango warango@vmware.com

Signed-off-by: Wendy Arango <warango@vmware.com>
@warango4 warango4 marked this pull request as ready for review January 17, 2023 22:13
Copy link
Copy Markdown
Contributor

@shaheerkootteeri shaheerkootteeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warango4 warango4 merged commit 5dca22f into vmware-tanzu:main Jan 20, 2023
@warango4 warango4 deleted the issue424 branch January 20, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support unsetting --git* flags by passing empty string ( "" )

5 participants