Skip to content

Conversation

@cfryanr
Copy link
Contributor

@cfryanr cfryanr commented Aug 9, 2024

Release note:

NONE

@cfryanr
Copy link
Contributor Author

cfryanr commented Aug 9, 2024

@joshuatcasey I cancelled a CI job to prevent this PR from running through the whole pipeline, since it can only possibly effect the lint job. If the lint job passes, then I propose that we merge this.

@cfryanr cfryanr requested a review from joshuatcasey August 9, 2024 16:29
@cfryanr
Copy link
Contributor Author

cfryanr commented Aug 9, 2024

The lint CI job passed while using the new linter version here: https://ci.pinniped.dev/teams/main/pipelines/pull-requests/jobs/lint/builds/646#L66b59442:5

@codecov
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.19%. Comparing base (5e6f6a1) to head (00f6f39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2044   +/-   ##
=======================================
  Coverage   31.19%   31.19%           
=======================================
  Files         366      366           
  Lines       61191    61191           
=======================================
  Hits        19089    19089           
  Misses      41569    41569           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey
Copy link
Contributor

force merging since this doesn't impact anything but lint

@joshuatcasey joshuatcasey merged commit 1eb6145 into main Aug 9, 2024
@joshuatcasey joshuatcasey deleted the upgrade_lint branch August 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants