refactor and fix comments

[ashish-amarnath]

Release note:

[netlify]

✅ Deploy Preview for pinniped-dev canceled.

Name	Link
🔨 Latest commit	ab2c2e3
🔍 Latest deploy log	https://app.netlify.com/sites/pinniped-dev/deploys/66ec8bcf9d94f50008f8b818

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.14%. Comparing base (65b93f0) to head (ab2c2e3).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/upstreamldap/upstreamldap.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   31.13%   31.14%           
=======================================
  Files         368      368           
  Lines       60970    60971    +1     
=======================================
+ Hits        18985    18988    +3     
+ Misses      41461    41458    -3     
- Partials      524      525    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cfryanr]

This should happen before calling Start, because if you call Start and then return an error, then you are leaking the goroutines that were started by Start. The subsequent call to StartTLS will clean up these goroutines if needed in the case of an error inside StartTLS. So we should avoid any code path that calls Start without calling StartTLS here.