Skip to content

Conversation

@cfryanr
Copy link
Contributor

@cfryanr cfryanr commented Nov 4, 2024

Fixes #2089.

Release note:

Fixes a bug introduce in Pinniped v0.33.0 where changing the `spec.audience` and/or `spec.claims` fields of an existing JWTAuthenticator (without changing any other spec fields) did not take effect until the next time the Concierge pods are restarted, even though those spec changes should take effect immediately.

@netlify
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for pinniped-dev canceled.

Name Link
🔨 Latest commit a7edbd1
🔍 Latest deploy log https://app.netlify.com/sites/pinniped-dev/deploys/67295a846632eb00085045fe

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.27%. Comparing base (587e6fb) to head (a7edbd1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   31.27%   31.27%   -0.01%     
==========================================
  Files         371      371              
  Lines       61119    61123       +4     
==========================================
+ Hits        19115    19116       +1     
- Misses      41480    41482       +2     
- Partials      524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr mentioned this pull request Nov 4, 2024
20 tasks
@cfryanr cfryanr enabled auto-merge November 4, 2024 23:49
@cfryanr cfryanr merged commit febbee3 into main Nov 5, 2024
@cfryanr cfryanr deleted the jwtauthenticator_bug branch November 5, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing some JWTAuthenticator spec values does not take effect until the next pod reload

4 participants