temporarily avoid upgrades to kube v0.32.0 without using replace directives for direct deps #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for pinniped-dev canceled.
|
cfryanr
changed the title
cfryanr
changed the title
Contributor
|
Note how the |
joshuatcasey
approved these changes
Dec 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2166 +/- ##
==========================================
- Coverage 31.95% 31.94% -0.01%
==========================================
Files 379 379
Lines 62098 62098
==========================================
- Hits 19843 19840 -3
- Misses 41724 41727 +3
Partials 531 531 ☔ View full report in Codecov by Sentry. |
joshuatcasey
force-pushed
the
avoid_kube_32
branch
from
b29cb2e to
f441714
Compare
joshuatcasey
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2165. This PR tries to avoid the problems described by my comments in #2165. In this PR, I lock the version of the Kubernetes packages by using an override config for our dependency-bumping automation, instead of using
replacedirectives for our direct dependencies.This PR also bumps build image to latest in Dockerfiles, and bumps the version of
github.com/chromedp/cdprotobecause there are new versions available for those.Release note: