Downgrade cdproto to the version selected by current chromedp version #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinniped-dev canceled.
|
joshuatcasey
approved these changes
Feb 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
=======================================
Coverage 32.03% 32.03%
=======================================
Files 379 379
Lines 62166 62166
=======================================
+ Hits 19913 19915 +2
+ Misses 41722 41720 -2
Partials 531 531 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
cfryanr
force-pushed
the
downgrade_cdproto
branch
from
87ba9e7 to
0e930b3
Compare
Closed
joshuatcasey
force-pushed
the
downgrade_cdproto
branch
from
b4bfd5f to
0e930b3
Compare
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade cdproto to the version selected by current chromedp version.
Change our dependency bumping automation to avoid using the bleeding edge version of cdproto.
Also upgrade to the new version of x/net.
Release note: