update docs and tests for new internal CI #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfryanr
changed the title
cfryanr
commented
Jun 30, 2025
|
|
||
| t.Run("using externally provided TLS serving cert with stringData", func(t *testing.T) { | ||
| if env.Proxy == "" { | ||
| t.Skip("Skipping ClusterIP test because squid proxy is not present") |
Contributor
Author
There was a problem hiding this comment.
Note to reviewers: these tests messed with the CredentialIssuer's spec a lot. When they take away the part of the spec which configures the annotation which tells GKE to only assign internal IPs to the load balancer, then the load balancer gets confused and stops working. To solve this, I'm skipping these tests except on Kind clusters, which still gives us good enough coverage for these behaviors.
Contributor
Author
|
Note to reviewers: please ignore the image scan failure. We need to upgrade to the latest Golang, but I don't want to do that until we get all our other pipelines working. |
joshuatcasey
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs and integration tests for the new CI system. Unfortunately, we can't use public IPs anymore.
Please note that I am also using this to test that the new CI system's
pull-requestspipeline works.Release note: